Refactor self-profile S3 uploading #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies uploading of self-profile files to S3 so that it no longer overlaps with benchmark execution. The self-profile files are now uploaded after all configurations of a single benchmark (crate) are finished.
This should in theory reduce noise a little bit, and it should also make it easier to further refactor the S3 uploads in the future, e.g. if we want to upload them all at the very end of the collection (and perhaps use a different timeout for the uploads, so that slow uploads don't affect/timeout the benchmark runs as they do now).
This also makes sure that we wait for all the uploads to finish. The current code does not wait for the last S3 upload for a given benchmark to finish (!).