Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling for performing Josh synces #2183

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 30, 2024

Accompanying rustc PR: rust-lang/rust#134907. This PR should probably be merged before that one, but it doesn't really matter, I think.

The josh sync code was adapted from the miri repository.

@jieyouxu jieyouxu added A-josh Area: `josh` subtree sync A-CI Area: CI WG-rustc-dev-guide Working group: rustc-dev-guide S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Dec 30, 2024
@jieyouxu jieyouxu self-assigned this Dec 30, 2024
@jieyouxu jieyouxu removed the A-CI Area: CI label Dec 30, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the tooling LGTM, cc @rust-lang/wg-rustc-dev-guide (maybe @camelid can also take a look?)

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
Turn rustc-dev-guide into a Josh subtree

Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/196385-t-compiler.2Fwg-rustc-dev-guide/topic/a.20move.20to.20main.20repo.20.28rust-lang.2Frust.29).

Accompanying rustc-dev-guide PR: rust-lang/rustc-dev-guide#2183

I didn't create a bootstrap step for rustc-dev-guide yet, because the rustc-dev-guide version that we currently use in this repo doesn't have linkcheck enabled and that fails tests.

The subtree starts with commit [ad93c5f1c49f2aeb45f7a4954017b1e607df9f5e](rust-lang/rustc-dev-guide@ad93c5f).

What I did:
```
export DIR=src/doc/rustc-dev-guide

# Remove submodule
git submodule status ${DIR}
git submodule deinit ${DIR}
git rm -r --cached ${DIR}
rm -rf ${DIR}
# Remove rustc-dev-guide from .gitmodules
git commit -m"Removed `${DIR}` submodule"

# Import history with josh
git fetch https://github.com/rust-lang/rustc-dev-guide ad93c5f1c49f2aeb45f7a4954017b1e607df9f5e
josh-filter ':prefix=src/doc/rustc-dev-guide' FETCH_HEAD
git merge --allow-unrelated FILTERED_HEAD

# A few follow-up cleanup commits
```

r? ehuss
@jieyouxu jieyouxu merged commit bd2cfd2 into rust-lang:master Jan 2, 2025
1 check passed
@jieyouxu
Copy link
Member

jieyouxu commented Jan 2, 2025

Thanks for working on this!

@Kobzol Kobzol deleted the josh-sync branch January 2, 2025 07:58
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 3, 2025

yippee :3

BoxyUwU pushed a commit to BoxyUwU/rustc-dev-guide that referenced this pull request Jan 4, 2025
Kobzol added a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 4, 2025
Kobzol added a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 5, 2025
Kobzol added a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 5, 2025
Kobzol added a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-josh Area: `josh` subtree sync S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content WG-rustc-dev-guide Working group: rustc-dev-guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants