Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS access mir opt test and remove stale files #97570

Merged
merged 1 commit into from
May 31, 2022

Conversation

JakobDegen
Copy link
Contributor

Thanks @pietroalbini for noticing that the TLS test was not doing what it was supposed to. Switched to PreCodegen because SimplifyCfg does not run on opt level 0.

Also addresses the easy part of #97564 .

r? rust-lang/mir-opt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2022
@tmiasko
Copy link
Contributor

tmiasko commented May 31, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2022

📌 Commit e60d8b6 has been approved by tmiasko

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 31, 2022
Fix TLS access mir opt test and remove stale files

Thanks `@pietroalbini` for noticing that the TLS test was not doing what it was supposed to. Switched to `PreCodegen` because `SimplifyCfg` does not run on opt level 0.

Also addresses the easy part of rust-lang#97564 .

r? rust-lang/mir-opt
@bors
Copy link
Contributor

bors commented May 31, 2022

⌛ Testing commit e60d8b6 with merge 0595ea1...

@bors
Copy link
Contributor

bors commented May 31, 2022

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 0595ea1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 31, 2022
@bors bors merged commit 0595ea1 into rust-lang:master May 31, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 31, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0595ea1): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.2% 2.2% 1
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-1.1% -1.1% 3
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
3.4% 5.1% 2
Improvements 🎉
(primary)
-2.8% -2.8% 1
Improvements 🎉
(secondary)
-3.3% -3.3% 1
All 😿🎉 (primary) -2.8% -2.8% 1

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
2.1% 2.1% 1
Regressions 😿
(secondary)
3.8% 4.2% 2
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 2.1% 2.1% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@JakobDegen JakobDegen deleted the dse-test branch June 1, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants