Remove unneeded cursor pointer rule on mobile sidebar #93212
Conversation
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
|
And even if iOS and Android didn’t actually support using mice, this still seems like a wrong way of thinking about it. Narrow screens aren’t just touchscreen smartphones. They also show up when you use a tiling window manager to put a desktop browser in a narrow window. |
|
It's true mobile devices can have mice. But actually there's a better reason to get rid of this rule: it's not needed anymore and we should defer to the browser's choice of what cursor to use. The rule was introduced in dc2c972, when the sidebar toggle was a link pretending to be a button. It's now a button, so the browser will give us the appropriate cursor automatically. r=me if @notriddle agrees with the above analysis. |
|
That’s fine. I just don’t want it showing an I-bar. |
|
Thanks you both for the arguments. TIL. :) @bors: r=jsha rollup |
|
📌 Commit 9f30dd9 has been approved by |
bors
added
S-waiting-on-bors
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92513 (std: Implement try_reserve and try_reserve_exact on PathBuf) - rust-lang#93152 (Fix STD compilation for the ESP-IDF target (regression from CVE-2022-21658)) - rust-lang#93186 (Fix link to CVE-2022-21658) - rust-lang#93188 (rustdoc: fix bump down typing search on Safari) - rust-lang#93212 (Remove unneeded cursor pointer rule on mobile sidebar) - rust-lang#93231 (adjust sidebar link brightness) - rust-lang#93241 (Fix brief appearance of rust logo in the sidebar) - rust-lang#93253 (Update theme on pageshow event) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Since it's on mobile, there isn't much point in this rule...
r? @jsha