Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest to add missing feature when using gated const features #71902

Merged
merged 1 commit into from
May 5, 2020
Merged

Suggest to add missing feature when using gated const features #71902

merged 1 commit into from
May 5, 2020
+70 −0

Conversation

mibac138
Copy link
Contributor

@mibac138 mibac138 commented May 4, 2020

Fixes #71797

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2020
@varkor
Copy link
Member

varkor commented May 4, 2020

This looks great, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 4, 2020

📌 Commit 7386736 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 4, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2020
@bors
Auto merge of rust-lang#71907 - Dylan-DPC:rollup-z8iaqlv, r=Dylan-DPC
04689e2 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#71587 (Report cannot move errors in promoted MIR)
 - rust-lang#71711 (Updates to some ignored tests)
 - rust-lang#71845 (Add const examples)
 - rust-lang#71878 (Add remove_current_as_list to LinkedList's CursorMut)
 - rust-lang#71881 (Correctly handle UEFI targets as Windows-like when emitting sections for LLVM bitcode)
 - rust-lang#71883 (add a missing "at" in a comment)
 - rust-lang#71891 (¬∃x. ¬y => ∀x. y)
 - rust-lang#71892 (Update btree_map::VacantEntry::insert docs to actually call insert)
 - rust-lang#71902 (Suggest to add missing feature when using gated const features)
 - rust-lang#71904 (fix typo in function name)

Failed merges:

r? @ghost
@bors bors merged commit ad74ce9 into rust-lang:master May 5, 2020
@mibac138 mibac138 deleted the const-feature-diag branch September 21, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some unstable const features do not indicate the right feature flag in their diagnostics
4 participants
@mibac138 @rust-highfive @varkor @bors