-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom backtrace output for Fuchsia #64133
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
For some context this is coupled with rust-lang/backtrace-rs#245 being published, and I think the last few commits I've just pushed there may help simplify the integration here (and even delete a bunch of code!) |
Ok I've merged that PR and published a new version on crates.io, @cramertj want to update the support here to use it? |
@alexcrichton great, thanks! will do. |
Closing this, as I think a fresh PR would be a better start. |
This is... not my favorite code that I've ever written. This lovely platform-agnostic module is no longer platform-agnostic. I considered breaking it up more, but the public API for other crates has to remain roughly the same in order to fulfill their needs on other platforms, and the actual quantity of cfg'd code here is fairly small-- it seems wrong to introduce a non-sys-common
sys/fuchsia/backtrace.rs
andsys/everything_but_fuchsia/backtrace.rs
. Let me know if you have better suggestions for organizing this.r? @alexcrichton