-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search other library paths when loking for link objects #56397
Conversation
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
e6a2533
to
68d88f7
Compare
Would it be possible to add a test for this new behavior? |
I'd also like to see a test added for this, if possible. I'd recommend adding a |
68d88f7
to
196f740
Compare
I've tried creating a
This is expected since I may not have the |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@petrhosek No, I don't believe that exists. In any case, you do need the target installed here in order to build |
196f740
to
b13a130
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
b13a130
to
22b526e
Compare
@bors r+ |
📌 Commit 22b526e has been approved by |
Search other library paths when loking for link objects Support the case when link objects are not located in Rust sysroot but in other locations which could be specify through library paths.
💔 Test failed - status-appveyor |
Failed for 32-bit Windows MSVC.
|
8c3e180
to
cf6079b
Compare
📌 Commit cf6079b5b1522b4a8d22021aee54432de09894cc has been approved by |
⌛ Testing commit cf6079b5b1522b4a8d22021aee54432de09894cc with merge 99b48df63b561db856d1ffbdbf9a9d8d86ca9f8b... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry travis-ci/travis-ci#9696 Why the fix is still not deployed 🤔 |
⌛ Testing commit cf6079b5b1522b4a8d22021aee54432de09894cc with merge d3e585a9887844d04ab3dadc65e39f1bd452667a... |
💔 Test failed - status-appveyor |
The new test failed on 32-bit MinGW.
|
Support the case when link objects are not located in Rust sysroot but in other locations which could be specify through library paths.
cf6079b
to
6d9640b
Compare
@bors r+ |
📌 Commit 6d9640b has been approved by |
Search other library paths when loking for link objects Support the case when link objects are not located in Rust sysroot but in other locations which could be specify through library paths.
☀️ Test successful - status-appveyor, status-travis |
Support the case when link objects are not located in Rust sysroot
but in other locations which could be specify through library paths.