Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search other library paths when loking for link objects #56397

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

petrhosek
Copy link
Contributor

Support the case when link objects are not located in Rust sysroot
but in other locations which could be specify through library paths.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2018
@rust-highfive

This comment has been minimized.

@Centril
Copy link
Contributor

Centril commented Dec 1, 2018

Would it be possible to add a test for this new behavior?

@cramertj
Copy link
Member

cramertj commented Dec 3, 2018

I'd also like to see a test added for this, if possible. I'd recommend adding a run-make-fulldeps test like these ones. If it's proving too challenging to manufacture a link object outside of the sysroot to pull in, then I'd be fine landing this without test (though others may have a different opinion?).

@petrhosek
Copy link
Contributor Author

I've tried creating a run-make-fulldeps but I have problem getting to work. I'm getting the following error when trying to run the test:

error[E0463]: can't find crate for `std`
  |
  = note: the `x86_64-fuchsia` target may not be installed

This is expected since I may not have the x86_64-fuchsia installed, but that shouldn't be necessary to run the test. Does rustc have an option to just print out the invocation without running it akin to Clang's -###? I believe that's what's needed here.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:005310c9:start=1544153217852572577,finish=1544153280642527755,duration=62789955178
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:55:26] 
[00:55:26] running 120 tests
[00:55:29] i..ii...iii..iiii.....i...i..........i..iii.............i.....i.....ii...i..i.ii..............i...i. 100/120
[00:55:29] i.ii.i.....iiii.....
[00:55:29] 
[00:55:29]  finished in 3.524
[00:55:29] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:55:44] 
[00:55:44] running 118 tests
[00:56:07] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[00:56:11] ......iii.i.....ii
[00:56:11] 
[00:56:11]  finished in 27.777
[00:56:11] travis_fold:end:test_debuginfo

---
travis_time:start:test_run-make-fulldeps
Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:21:44] 
[01:21:44] running 194 tests
[01:22:08] .......................................................................................F............ 100/194
[01:23:06] .............................................................................................test [run-make] run-make-fulldeps/long-linker-command-lines has been running for over 60 seconds
-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64asmprinter aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils all all-targets amdgpu amdgpuasmparser amdgpuasmprinter amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armasmprinter armcodegen armdesc armdisassembler arminfo asmparser asmprinter binaryformat bitreader bitwriter bpf bpfasmprinter bpfcodegen bpfdes-Wno-comment -ffunction-sections -fdata-sections -O2 -DNDEBUG -g1  -fno-exceptions -DLLVM_BUILD_GLOBAL_ISEL -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:26:13] 
[01:26:13] 
[01:26:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:26:13] Build completed unsuccessfully in 0:41:19
[01:26:13] Build completed unsuccessfully in 0:41:19
[01:26:13] Makefile:58: recipe for target 'check' failed
[01:26:13] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:05673348
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Dec  7 04:54:23 UTC 2018
---
travis_time:end:03125622:start=1544158466131307446,finish=1544158466232321014,duration=101013568
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0d4306a6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:087495b8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cramertj
Copy link
Member

cramertj commented Dec 7, 2018

@petrhosek No, I don't believe that exists. In any case, you do need the target installed here in order to build fn main() {}, since that has dependencies on the x86_64-fuchsia standard library (which is only installed when that target is installed).

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:033b6e2c:start=1544213093234157703,finish=1544213148633480583,duration=55399322880
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:53:03] 
[00:53:03] running 120 tests
[00:53:06] i..ii...iii..iiii.....i...i..........i..iii.............i.....i.....ii...i..i.ii..............i...ii 100/120
[00:53:07] ..ii.i.....iiii.....
[00:53:07] 
[00:53:07]  finished in 3.598
[00:53:07] travis_fold:end:test_codegen

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:53:21] 
[00:53:21] running 118 tests
[00:53:44] .iiiii...i.....i..i...i..i.i..i.i..i.....i..i....i..........iiii.........i.i....i...i.......ii.i.i.i 100/118
[00:53:48] ......iii.i.....ii
[00:53:48] 
[00:53:48]  finished in 26.928
[00:53:48] travis_fold:end:test_debuginfo

---
travis_time:start:test_run-make-fulldeps
Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:18:27] 
[01:18:27] running 194 tests
[01:18:50] .......................................................................................F............ 100/194
[01:19:48] .............................................................................................test [run-make] run-make-fulldeps/long-linker-command-lines has been running for over 60 seconds
[01:22:31] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:503:22
[01:22:31] failures:
[01:22:31] 
[01:22:31] ---- [run-make] run-make-fulldeps/libs-search-path stdout ----
---
[01:22:31] 
[01:22:31] ------------------------------------------
[01:22:31] stderr:
[01:22:31] ------------------------------------------
[01:22:31] make[1]: *** No targets.  Stop.
[01:22:31] ------------------------------------------
[01:22:31] 
[01:22:31] 
[01:22:31] thread '[run-make] run-make-fulldeps/libs-search-path' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3284:9
[01:22:31] 
[01:22:31] 
[01:22:31] failures:
[01:22:31]     [run-make] run-make-fulldeps/libs-search-path
[01:22:31]     [run-make] run-make-fulldeps/libs-search-path
[01:22:31] 
[01:22:31] test result: FAILED. 193 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:22:31] 
[01:22:31] 
[01:22:31] 
[01:22:31] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gngondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader lanai lanaiasmparser lanaiasmprinter lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mcdisassembler mcjit mcparser mips mipsasmparser mipsasmprinter mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmprinter msp430codegen msp430desc msp430info native nativecodegen nvptx nvptxasmprinter nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes powerpc powerpcasmparser powerpcasmprinter powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata runtimedyld scalaropts selectiondag sparc sparcasmparser sparcasmprinter sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzasmprinter systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target transformutils vectorize x86 x86asmparser x86asmprinter x86codegen x86desc x86disassembler x86info x86utils xcore xcoreasmprinter xcorecodegen xcoredesc xcoredisassembler xcoreinfo" "--llvm-cxxflags" "-I/usr/lib/llvm-5.0/include -std=c++0x -fuse-ld=gold -Wl,--no-keep-files-mapped -Wl,--no-map-whole-files -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O2 -DNDEBUG -g1  -fno-exceptions -DLLVM_BUILD_GLOBAL_ISEL -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--adb-path" "nknown-linux-gnu
58684 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/deps
56896 ./src/llvm/test/MC
56648 ./obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps
56108 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release/build
---
travis_time:end:084cf5eb:start=1544218109914566994,finish=1544218109921618017,duration=7051023
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:08b962db
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 10, 2018

📌 Commit 22b526e has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2018
@bors
Copy link
Contributor

bors commented Dec 10, 2018

⌛ Testing commit 22b526e with merge 3751f83...

bors added a commit that referenced this pull request Dec 10, 2018
Search other library paths when loking for link objects

Support the case when link objects are not located in Rust sysroot
but in other locations which could be specify through library paths.
@bors
Copy link
Contributor

bors commented Dec 10, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 10, 2018
@kennytm
Copy link
Member

kennytm commented Dec 11, 2018

Failed for 32-bit Windows MSVC.

Error: cannot match: /c/projects/rust/build/i686-pc-windows-msvc/test/run-make-fulldeps/libs-search-path/libs-search-path/obj/crt2.o

error: Error loading target specification: Could not find specification for target "x86_64-windows-msvc"
  |
  = help: Use `--print target-list` for a list of built-in targets

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2018
@petrhosek petrhosek force-pushed the file-search branch 2 times, most recently from 8c3e180 to cf6079b Compare December 18, 2018 03:19
@bors
Copy link
Contributor

bors commented Dec 18, 2018

📌 Commit cf6079b5b1522b4a8d22021aee54432de09894cc has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2018
@bors
Copy link
Contributor

bors commented Dec 18, 2018

⌛ Testing commit cf6079b5b1522b4a8d22021aee54432de09894cc with merge 99b48df63b561db856d1ffbdbf9a9d8d86ca9f8b...

@bors
Copy link
Contributor

bors commented Dec 18, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:25:18] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "cargotest", path: "src/tools/cargotest", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 1.000
[01:25:18] testing https://github.com/servo/webrender
[01:25:18] Initialized empty Git repository in /checkout/obj/build/ct/webrender/.git/
[01:25:18] fatal: Could not parse object '57250b2b8fa63934f80e5376a29f7dcb3f759ad6'.
[01:25:38] fatal: unable to access 'https://github.com/servo/webrender/': Could not resolve host: github.com
[01:25:38] thread 'main' panicked at 'assertion failed: status.success()', src/tools/cargotest/main.rs:124:13
[01:25:38] 
[01:25:38] 
[01:25:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[01:25:38] expected success, got: exit code: 101
[01:25:38] expected success, got: exit code: 101
[01:25:38] 
[01:25:38] 
[01:25:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/pretty src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/test/run-fail-fulldeps/pretty src/tools/cargo src/tools/cargotest
[01:25:38] Build completed unsuccessfully in 0:31:20
[01:25:38] make: *** [check-aux] Error 1
[01:25:38] Makefile:60: recipe for target 'check-aux' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06abc3f1
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Dec 18 06:49:42 UTC 2018
---
travis_time:end:0663b014:start=1545115785283612624,finish=1545115785289895452,duration=6282828
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0884afa0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:start:crashlog
obj/cores/core.30942.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
[New LWP 30942]
warning: Could not load shared library symbols for 8 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `rustc --crate-name foo src/lib.rs --color never --crate-type lib --emit=dep-inf'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007ffae8737428 in ?? ()
#0  0x00007ffae8737428 in ?? ()
#1  0x00007ffae873902a in ?? ()
#2  0x0000000000000020 in ?? ()
#3  0x0000000000000000 in ?? ()
travis_time:end:0884afa0:start=1545115785296699532,finish=1545115786666394614,duration=1369695082
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07ee5072
travis_time:start:07ee5072
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:091023ca
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Dec 18, 2018

@bors retry travis-ci/travis-ci#9696

Why the fix is still not deployed 🤔

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2018
@bors
Copy link
Contributor

bors commented Dec 18, 2018

⌛ Testing commit cf6079b5b1522b4a8d22021aee54432de09894cc with merge d3e585a9887844d04ab3dadc65e39f1bd452667a...

@bors
Copy link
Contributor

bors commented Dec 18, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2018
@kennytm
Copy link
Member

kennytm commented Dec 18, 2018

The new test failed on 32-bit MinGW.

------------------------------------------
stderr:
------------------------------------------
error[E0463]: can't find crate for `std`
  |
  = note: the `x86_64-pc-windows-gnu` target may not be installed

Support the case when link objects are not located in Rust sysroot
but in other locations which could be specify through library paths.
@cramertj
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2018

📌 Commit 6d9640b has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 19, 2018
@bors
Copy link
Contributor

bors commented Dec 19, 2018

⌛ Testing commit 6d9640b with merge e7b4bc3...

bors added a commit that referenced this pull request Dec 19, 2018
Search other library paths when loking for link objects

Support the case when link objects are not located in Rust sysroot
but in other locations which could be specify through library paths.
@bors
Copy link
Contributor

bors commented Dec 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing e7b4bc3 to master...

@bors bors merged commit 6d9640b into rust-lang:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants