Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E0520 to new error format #36135

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Update E0520 to new error format #36135

merged 1 commit into from
Aug 31, 2016

Conversation

0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Aug 30, 2016

Fixes #36112.
Part of #35233.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@TimNN
Copy link
Contributor

TimNN commented Aug 30, 2016

It looks like you have a tidy failure:

/build/src/test/compile-fail/E0520.rs:30: line longer than 100 chars

@0xmohit 0xmohit force-pushed the pr/error-code-E0520 branch from 0e00b99 to 13fef3a Compare August 30, 2016 11:31
@0xmohit
Copy link
Contributor Author

0xmohit commented Aug 30, 2016

Thanks, @TimNN. Should be fixed now.

@0xmohit 0xmohit force-pushed the pr/error-code-E0520 branch from 13fef3a to 77cd09a Compare August 30, 2016 14:50
@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 30, 2016

📌 Commit 77cd09a has been approved by jonathandturner

@0xmohit
Copy link
Contributor Author

0xmohit commented Aug 30, 2016

The following appears unrelated:

test [run-pass] run-pass/issue-36023.rs ... FAILED

@TimNN
Copy link
Contributor

TimNN commented Aug 30, 2016 •
edited
Loading

Yes, thats a known travis failure (#36138).

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36135 - 0xmohit:pr/error-code-E0520, r=jona…
fb574b2 
…thandturner

Update E0520 to new error format

Fixes rust-lang#36112.
Part of rust-lang#35233.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36135 - 0xmohit:pr/error-code-E0520, r=jona…
0ce3724 
…thandturner

Update E0520 to new error format

Fixes rust-lang#36112.
Part of rust-lang#35233.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36135 - 0xmohit:pr/error-code-E0520, r=jona…
7b40ad2 
…thandturner

Update E0520 to new error format

Fixes rust-lang#36112.
Part of rust-lang#35233.

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36135 - 0xmohit:pr/error-code-E0520, r=jona…
f3ce9fd 
…thandturner

Update E0520 to new error format

Fixes rust-lang#36112.
Part of rust-lang#35233.

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Merged
bors added a commit that referenced this pull request Aug 31, 2016
@bors
Auto merge of #36166 - jonathandturner:rollup, r=jonathandturner
7a187c3 
Rollup of 16 pull requests

- Successful merges: #35758, #35926, #36050, #36079, #36085, #36089, #36101, #36130, #36134, #36135, #36136, #36140, #36141, #36147, #36148, #36165
- Failed merges:
@bors bors merged commit 77cd09a into rust-lang:master Aug 31, 2016
@0xmohit 0xmohit deleted the pr/error-code-E0520 branch September 1, 2016 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xmohit @rust-highfive @TimNN @sophiajt @bors