Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupport wget #34062

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Unsupport wget #34062

merged 1 commit into from
Jun 6, 2016

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Jun 3, 2016

wget support was removed in #32942 (search for wget in diff), but configure wasn't updated. wget support was introduced in #7498 for Windows, but we now use PowerShell on Windows.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@sanxiyn
Copy link
Member Author

sanxiyn commented Jun 3, 2016

While testing this, I updated error message from probe_need.

Before: needed, but unable to find any of: CFG_PYTHON python2.7 python2 python
After: CFG_PYTHON needed, but unable to find any of: python2.7 python2 python

@nagisa
Copy link
Member

nagisa commented Jun 5, 2016

Seems like a trivially correct change.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 5, 2016

📌 Commit a7e96af has been approved by nagisa

@eddyb
Copy link
Member

eddyb commented Jun 5, 2016

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Jun 6, 2016
Unsupport wget

wget support was removed in rust-lang#32942 (search for wget in diff), but configure wasn't updated. wget support was introduced in rust-lang#7498 for Windows, but we now use PowerShell on Windows.
@eddyb eddyb merged commit a7e96af into rust-lang:master Jun 6, 2016
@sanxiyn sanxiyn deleted the no-wget branch June 7, 2016 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants