Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ast attributes every where (remove HIR attributes). #28399

Merged
merged 1 commit into from
Sep 16, 2015

Conversation

nrc
Copy link
Member

@nrc nrc commented Sep 14, 2015

This could be a [breaking-change] if your lint or syntax extension (is that even possible?) uses HIR attributes or literals.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

r? @nikomatsakis

(or anyone else in @rust-lang/compiler)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 14, 2015

📌 Commit 9596009 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Sep 15, 2015

☔ The latest upstream changes (presumably #28274) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Sep 15, 2015

☔ The latest upstream changes (presumably #28413) made this pull request unmergeable. Please resolve the merge conflicts.

This could be a [breaking-change] if your lint or syntax extension (is that even possible?) uses HIR attributes or literals.
@nrc
Copy link
Member Author

nrc commented Sep 15, 2015

@bors: r=nikomatsakis

@bors
Copy link
Contributor

bors commented Sep 15, 2015

📌 Commit e9f1b06 has been approved by nikomatsakis

bors added a commit that referenced this pull request Sep 16, 2015
This could be a [breaking-change] if your lint or syntax extension (is that even possible?) uses HIR attributes or literals.
@bors
Copy link
Contributor

bors commented Sep 16, 2015

⌛ Testing commit e9f1b06 with merge fc4d566...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants