Use a queue to keep track of running and blocked tasks in rust_sched_loop #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loop. Create a new data structure called rust_task_queue that holds a circular doubly linked list of tasks. This is used in rust_sched_loop to keep track of running and blocked tasks, moving tasks between the two lists should be more efficient.
|
also, if this lands then it looks like rt/util/index_list.h and rt/util/synchronized_indexed_list.h can be removed entirely. |
|
After thinking about this more at lunch I'm still not convinced that either way is better. One we add automatic preemption points and time slice accounting the way that tasks are scheduled will need to change again. I do like the idea of getting rid of indexed_list and synchronized_indexed_list. I'm not even sure what synchronized_indexed_list is used for and why. |
|
synchronized_indexed_list isn't used anywhere and could probably be removed regardless. |
|
This approach turned out to be wrong. We are not going to merge it. Please accept my apologies. |
|
no problem! |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally had the linked list logic in sched_loop but it was messy, so I moved it out to a separate data structure class. Not sure how worth it this will be when blocked_tasks gets removed altogether, but here it is.
Fixes #2028