Remove the unneeded Sized bound on TypeId creation #20662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bound is probably unintentional and is unnecessarily constricting.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Why is it constricting, it admits more concrete types for T? |
|
crap, ignore me |
|
Seems reasonable. |
|
Just a friendly remind to be sure to run tests! (this ICEs in stage0 libcore, the very first thing we compile) |
|
@alexcrichton Weird, I ran EDIT: I may have misused the build system... further investigation pending. |
|
Ah I registered a new snapshot locally which must have triggered the error. |
|
@alexcrichton Nope, this does ICE. I did wrong things to the build system. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 7, 2015
This bound is probably unintentional and is unnecessarily constricting.
|
This wasn't actually merge (sorry didn't rebase this out), but feel free to reopen with the ICE fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bound is probably unintentional and is unnecessarily
constricting.