-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the manual page with new options #20129
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
cc @alexcrichton you'll probably be interested in this. |
.TP | ||
\fB\-\-out\-dir\fR DIR | ||
Write output to compiler-chosen filename in <dir>. Ignored if -o is specified. | ||
(default the current directory) | ||
Write output to compiler-chosen filename in <dir> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove the additional sentences "Ignored if -o is specified. (default the current directory)" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I was sure I saw rustc throw an error if both these flags were specified.
Thanks @nagisa! |
I think this is ready now and represents current rustc state well. (do I need to squash the commits or @bors will handle it?) |
This pull request updates the rustc manual page to represent post-rust-lang#19900 state of rustc options better. A bit unrelatedly, --help output is changed to fix some issues too: * -g and -O descriptions were changed from deprected flags to the new codegen flags. * dep-info value was moved from crate-type to emit flag. Fixes rust-lang#20111 Fixes rust-lang#20131
Done. |
This pull request updates the rustc manual page to represent current state of rustc option handling better. Moved the apparently deprecated options (rust-lang#19900) to their own section and added all the new codegen options. A bit unrelatedly, I also updated description of `-O` and `-g` flags to point to the new codegen options rather than old, deprecated ones. Fixes rust-lang#20111.
This pull request updates the rustc manual page to represent current state of rustc option handling better. Moved the apparently deprecated options (#19900) to their own section and added all the new codegen options.
A bit unrelatedly, I also updated description of
-O
and-g
flags to point to the new codegen options rather than old, deprecated ones.Fixes #20111.