Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use rust keyword for fake code #18933

Merged
merged 1 commit into from
Nov 16, 2014
Merged

Conversation

IanConnolly
Copy link
Contributor

As per IRC, fake rust is a bit too similar to real rust.

fn -> func for all code blocks marked notrust.

/cc @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

@alexcrichton
Copy link
Member

Moving assignee to @steveklabnik

@steveklabnik
Copy link
Member

Thanks!

@liigo
Copy link
Contributor

liigo commented Nov 13, 2014

Why not fn => function or fn => int?
func is bad here because it's not clear that it means function!

@barosl
Copy link
Contributor

barosl commented Nov 14, 2014

I second function, though I believe it doesn't matter much. We are already using : &int to denote a return type, so whatever the fn keyword may change to, it still requires some knowledge of the existing languages.

@IanConnolly
Copy link
Contributor Author

I'm not pushed either way, will leave it up to @steveklabnik.

@steveklabnik
Copy link
Member

I think it's fine as is.

@bors bors merged commit 769d49a into rust-lang:master Nov 16, 2014
lnicola added a commit to lnicola/rust that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants