import simd_ intrinsics

[folkertdev]

In most cases, we can import the simd intrinsics rather than redeclare them. Apparently, most of these tests were written before std::intrinsics::simd existed.

There are a couple of exceptions where we can't yet import:

• the intrinsics are not declared as const fn in the standard library, causing issues in the const-eval tests
• the simd_shuffle_generic function is not exposed from std::intrinsics
• the simd_fpow and simd_fpowi functions are not exposed from std::intrinsics (removed in remove simd_fpow and simd_fpowi #137595)
• some tests use no_core, and therefore cannot use std::intrinsics

r? @RalfJung

cc @workingjubilee do you have context on why some intrinsics are not exposed?

[workingjubilee]

there's a story behind simd_shuffle_generic

[workingjubilee]

I'm not aware of one for the fpow and fpowi ones.

[RalfJung]

the intrinsics are not declared as const fn in the standard library, causing issues in the const-eval tests

Only simd_insert and simd_extract can be used in const-eval. You can make them const fn in this PR if you want, then they should be usable for those tests.

the simd_shuffle_generic function is not exposed from std::intrinsics

Yeah that needs some highly experimental type system features so we cannot use it in core/std.

the simd_fpow and simd_fpowi functions are not exposed from std::intrinsics

Oh that's odd, could you open an issue?

some tests use no_core, and therefore cannot use std::intrinsics

👍

[RalfJung]

Why did you do this unrelated refactor? Makes the review harder...

[folkertdev]

the goal of this is the rustfmt::skip, otherwise this reformats to 3X the lines

[RalfJung]

But why would you format this at all?

It's generally not good to do drive-by formatting of previously unformatted files as part of an unrelated PR. That just makes the review harder than it has to be.

[folkertdev]

I've opened #137555 for the simd_fpow intrinsics. It really just looks like an oversight to me.

[bors]

☔ The latest upstream changes (presumably #137573) made this pull request unmergeable. Please resolve the merge conflicts.

[RalfJung]

Can you let me know when you rebased? (GH does not always send notifications for force-pushes.)

[folkertdev]

I've rebased (but not squashed yet, I'll do that at the very end)

Also, this PR will give merge conflicts with the simd_pow removal #137595

[bors]

☔ The latest upstream changes (presumably #137608) made this pull request unmergeable. Please resolve the merge conflicts.

[folkertdev]

I've rebased again, and undrafted because this should now not be blocked on anything

[folkertdev]

some mingw job failed with a connection error. Is there a way to restart that job besides closing/re-opening the PR?

[rustbot]

Some changes occurred to the platform-builtins intrinsics. Make sure the
LLVM backend as well as portable-simd gets adapted for the changes.

cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @rust-lang/wg-const-eval

[RalfJung]

I will approve this now since I like the cleanup. However, in the future, please respect the time of reviewers and do not perform any drive-by formatting changes.

@bors r+

[bors]

📌 Commit 038f4e2 has been approved by RalfJung

It is now in the queue for this repository.

[bors]

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.