Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize file_lock #136794

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Stabilize file_lock #136794

merged 1 commit into from
Feb 19, 2025
+5 −10

Conversation

cberner
Copy link
Contributor

@cberner cberner commented Feb 9, 2025

Closes #130994

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 9, 2025
@cberner
Copy link
Contributor Author

cberner commented Feb 9, 2025

@rustbot modify labels: +T-libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 9, 2025
@traviscross traviscross mentioned this pull request Feb 9, 2025
Closed
3 tasks
@cberner
Copy link
Contributor Author

cberner commented Feb 9, 2025

r? @joshtriplett

@rustbot rustbot assigned joshtriplett and unassigned thomcc Feb 9, 2025
@joshtriplett

This comment was marked as off-topic.

Sign in to view
@joshtriplett joshtriplett removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Feb 10, 2025
@joshtriplett

This comment was marked as off-topic.

Sign in to view
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2025
@cberner

This comment was marked as off-topic.

Sign in to view
@joshtriplett

This comment was marked as off-topic.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2025
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 11, 2025

📌 Commit 82af73d has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2025
@the8472
Copy link
Member

the8472 commented Feb 11, 2025 •
edited
Loading

@bors r- after libs-api discussion. There are some open questions in the tracking issue that need to be addressed.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2025
@m-ou-se
Copy link
Member

m-ou-se commented Feb 11, 2025

We'd like to figure out the situation with append-only files on windows before stabilization. See #130994 (comment)

@joshtriplett
Copy link
Member

I've addressed the issues via documentation PR #136876 ; once that PR is merged, this one can be merged.

@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 19, 2025

📌 Commit 82af73d has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 19, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
@bors
Auto merge of rust-lang#137284 - matthiaskrgr:rollup-deuhk46, r=matth…
f280acf 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#127793 (Added project-specific Zed IDE settings)
 - rust-lang#134995 (Stabilize const_slice_flatten)
 - rust-lang#136301 (Improve instant docs)
 - rust-lang#136347 (Add a bullet point to `std::fs::copy`)
 - rust-lang#136794 (Stabilize file_lock)
 - rust-lang#137094 (x86_win64 ABI: do not use xmm0 with softfloat ABI)
 - rust-lang#137227 (docs(dev): Update the feature-gate instructions)
 - rust-lang#137232 (Don't mention `FromResidual` on bad `?`)
 - rust-lang#137251 (coverage: Get hole spans from nested items without fully visiting them)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ce72b8d into rust-lang:master Feb 19, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 19, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
@rust-timer
Unrolled build for rust-lang#136794
45d5e0e 
Rollup merge of rust-lang#136794 - cberner:stabilize, r=joshtriplett

Stabilize file_lock

Closes rust-lang#130994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for File lock API
7 participants
@cberner @rustbot @joshtriplett @bors @the8472 @m-ou-se @thomcc