Update String::from_raw_parts safety requirements
#136775
Merged
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Amanieu
approved these changes
Feb 23, 2025
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 24, 2025
Update `String::from_raw_parts` safety requirements These have become out of sync with `Vec::from_raw_part`'s safety requirements, and are likely to diverge again. I think it's safest to just point at `Vec`'s requirements. rust-lang#119206 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2025
…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#136775 (Update `String::from_raw_parts` safety requirements) - rust-lang#137373 (Compile run-make-support and run-make tests with the bootstrap compiler) - rust-lang#137489 (remove `#[rustc_intrinsic_must_be_overridde]`) - rust-lang#137493 (configure.py: don't instruct user to run nonexistent program) - rust-lang#137516 (remove some unnecessary rustc_const_unstable) - rust-lang#137527 (Update stdarch) - rust-lang#137530 (DWARF mixed versions with LTO on MIPS) - rust-lang#137539 ( Add rustdoc-gui regression test for rust-lang#137082 ) - rust-lang#137543 (std: Fix another new symlink test on Windows) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#134655 (Stabilize `hash_extract_if`) - rust-lang#135933 (Explain how Vec::with_capacity is faithful) - rust-lang#136668 (Stabilize `core::str::from_utf8_mut` as `const`) - rust-lang#136775 (Update `String::from_raw_parts` safety requirements) - rust-lang#137109 (stabilize extract_if) - rust-lang#137349 (Implement `read_buf` for zkVM stdin) - rust-lang#137493 (configure.py: don't instruct user to run nonexistent program) - rust-lang#137516 (remove some unnecessary rustc_const_unstable) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2025
Rollup merge of rust-lang#136775 - robertbastian:patch-2, r=Amanieu Update `String::from_raw_parts` safety requirements These have become out of sync with `Vec::from_raw_part`'s safety requirements, and are likely to diverge again. I think it's safest to just point at `Vec`'s requirements. rust-lang#119206 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have gotten out of sync with
Vec::from_raw_part's safety requirements, and are likely to diverge again. I think it's safest to just point atVec's requirements.#119206 (comment)