Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infer linker flavor by linker name if it's sufficiently specific #136473

Merged
merged 1 commit into from
Feb 21, 2025
Merged

infer linker flavor by linker name if it's sufficiently specific #136473

merged 1 commit into from
Feb 21, 2025

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Feb 3, 2025

Fix: rustc does not infer llvm-bitcode-linker uses llbc linker flavor if targeting nvptx64-nvidia-cuda.

@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@jieyouxu jieyouxu added the A-linkers Area: linkers... you gotta love linkers label Feb 3, 2025
@lqd
Copy link
Member

lqd commented Feb 3, 2025

cc @petrochenkov

@petrochenkov petrochenkov self-assigned this Feb 3, 2025
@davidtwco davidtwco removed their assignment Feb 18, 2025
@petrochenkov
Copy link
Contributor

What is the motivation behind all the other changes besides adding a line for "llvm-bitcode-linker"?
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2025
@usamoi
Copy link
Contributor Author

usamoi commented Feb 20, 2025

What is the motivation behind all the other changes besides adding a line for "llvm-bitcode-linker"?

This was done incidentally. Do I need to revert these changes?

@petrochenkov
Copy link
Contributor

Yes, please, keep only the minimal necessary changes.

@usamoi usamoi force-pushed the infer_linker_hints branch from 0a16e4b to c23bf48 Compare February 20, 2025 12:00
@usamoi
Copy link
Contributor Author

usamoi commented Feb 20, 2025

These changes have been reverted.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 20, 2025
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Feb 20, 2025

📌 Commit c23bf48 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2025
@petrochenkov
Copy link
Contributor

@bors rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 20, 2025
@workingjubilee
Rollup merge of rust-lang#136473 - usamoi:infer_linker_hints, r=petro…
473787b 
…chenkov

infer linker flavor by linker name if it's sufficiently specific

Fix: `rustc` does not infer `llvm-bitcode-linker` uses `llbc` linker flavor if targeting `nvptx64-nvidia-cuda`.
@workingjubilee workingjubilee mentioned this pull request Feb 20, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2025
@bors
Auto merge of rust-lang#137339 - workingjubilee:rollup-esgu55d, r=wor…
2c9b4c5 
…kingjubilee

Rollup of 14 pull requests

Successful merges:

 - rust-lang#131651 (Create a generic AVR target: avr-none)
 - rust-lang#136473 (infer linker flavor by linker name if it's sufficiently specific)
 - rust-lang#136608 (Pass through of target features to llvm-bitcode-linker and handling them)
 - rust-lang#136985 (Do not ignore uninhabited types for function-call ABI purposes. (Remove BackendRepr::Uninhabited))
 - rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround)
 - rust-lang#137204 (Clarify MIR dialects and phases)
 - rust-lang#137270 (Fix `*-win7-windows-msvc` target since 26eeac1)
 - rust-lang#137298 (Check signature WF when lowering MIR body)
 - rust-lang#137299 (Simplify `Postorder` customization.)
 - rust-lang#137312 (Update references to cc_detect.rs)
 - rust-lang#137313 (Some codegen_llvm cleanups)
 - rust-lang#137318 (Workaround Cranelift not yet properly supporting vectors smaller than 128bit)
 - rust-lang#137322 (Update docs for default features of wasm targets)
 - rust-lang#137324 (Make x86 QNX target name consistent with other Rust targets)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Feb 20, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2025
@bors
Auto merge of rust-lang#137346 - workingjubilee:rollup-sxu05ms, r=wor…
a18bd8a 
…kingjubilee

Rollup of 12 pull requests

Successful merges:

 - rust-lang#131651 (Create a generic AVR target: avr-none)
 - rust-lang#134340 (Stabilize `num_midpoint_signed` feature)
 - rust-lang#136473 (infer linker flavor by linker name if it's sufficiently specific)
 - rust-lang#136608 (Pass through of target features to llvm-bitcode-linker and handling them)
 - rust-lang#136985 (Do not ignore uninhabited types for function-call ABI purposes. (Remove BackendRepr::Uninhabited))
 - rust-lang#137270 (Fix `*-win7-windows-msvc` target since 26eeac1)
 - rust-lang#137312 (Update references to cc_detect.rs)
 - rust-lang#137318 (Workaround Cranelift not yet properly supporting vectors smaller than 128bit)
 - rust-lang#137322 (Update docs for default features of wasm targets)
 - rust-lang#137324 (Make x86 QNX target name consistent with other Rust targets)
 - rust-lang#137338 (skip submodule updating logics on tarballs)
 - rust-lang#137340 (Add a notice about missing GCC sources into source tarballs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 921ef32 into rust-lang:master Feb 21, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 21, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2025
@rust-timer
Unrolled build for rust-lang#136473
023d730 
Rollup merge of rust-lang#136473 - usamoi:infer_linker_hints, r=petrochenkov

infer linker flavor by linker name if it's sufficiently specific

Fix: `rustc` does not infer `llvm-bitcode-linker` uses `llbc` linker flavor if targeting `nvptx64-nvidia-cuda`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
A-linkers Area: linkers... you gotta love linkers S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
7 participants
@usamoi @rustbot @lqd @petrochenkov @bors @davidtwco @jieyouxu