Pass deployment target to cc linker with -m*-version-min=
#136333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang supports many ways of passing the deployment target, and prefers that you use the `-target` flag for doing so. This works poorly work with configuration files and Zig CC though, so we use the older `-mmacosx-version-min=`, `-miphoneos-version-min=`, `-mtargetos=` etc. flags to pass the deployment target instead.
rustbot
added
S-waiting-on-review
|
r? compiler |
|
See rust-lang/cc-rs#1339 (comment); the cc-rs change may need to be improved. |
Yeah, the |
|
The related @rustbot author |
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang supports many ways of passing the deployment target, and prefers that you use the
-targetflag for doing so. This, however, works poorly work with Clang configuration files (at least before llvm/llvm-project#111387) and Zig CC.To support GCC, we already passed the deployment target using the older, more widely supported
-arch+-mmacosx-version-min=flag combination when compiling for macOS; let's do a similar thing for the other Apple targets too using-miphoneos-version-min=,-mtargetos=etc.Note that when passing the target triple to the LLVM backend, we still have to merge the deployment target into that.
See also the similar fix in
cc-rswhere the problem is more prominent, exactly because we did not already do it for macOS.@rustbot label O-apple
r? compiler
CC @thomcc @BlackHoleFox