Move std::pipe::* into std::io
#135583
Merged
Move std::pipe::* into std::io
#135583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
r=me once it passes CI. |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
force-pushed
the
move-pipe-to-io
branch
from
807d02c to
81d70f9
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
|
This PR modifies cc @jieyouxu |
|
r=me |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133700 (const-eval: detect more pointers as definitely not-null) - rust-lang#135290 (Encode constraints that hold at all points as logical edges in location-sensitive polonius) - rust-lang#135478 (Run clippy for rustc_codegen_gcc on CI) - rust-lang#135583 (Move `std::pipe::*` into `std::io`) - rust-lang#135612 (Include x scripts in tarballs) - rust-lang#135624 (ci: mirror buildkit image to ghcr) - rust-lang#135661 (Stabilize `float_next_up_down`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2025
Rollup merge of rust-lang#135583 - NobodyXu:move-pipe-to-io, r=joshtriplett Move `std::pipe::*` into `std::io` Resolve concern from final comment period rust-lang#127154 (comment)
riking
reviewed
Jan 25, 2025
| @@ -823,3 +823,20 @@ fn try_oom_error() { | |||
| let io_err = io::Error::from(reserve_err); | |||
| assert_eq!(io::ErrorKind::OutOfMemory, io_err.kind()); | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg(all(windows, unix, not(miri)))] | |||
There was a problem hiding this comment.
This cfg is never true because it expects a platform that is both windows and unix
There was a problem hiding this comment.
Ahhh damn thanks for spotting this
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve concern from final comment period #127154 (comment)