Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip locking span interner for some syntax context checks #128197

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Skip locking span interner for some syntax context checks #128197

merged 1 commit into from
Nov 15, 2024
+11 −9

Conversation

Alexendoo
Copy link
Member

  • from_expansion now never needs to consult the interner
  • eq_ctxt now only needs the interner when both spans are fully interned

@rustbot
Copy link
Collaborator

rustbot commented Jul 25, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 25, 2024
davidtwco
davidtwco approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies that this was left waiting so long, this slipped through the cracks, thanks for making that change.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2024

📌 Commit ad3f3c7 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#133047 - matthiaskrgr:rollup-9se1vth, r=matth…
e84902d 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#128197 (Skip locking span interner for some syntax context checks)
 - rust-lang#133040 ([rustdoc] Fix handling of footnote reference in footnote definition)
 - rust-lang#133043 (rustdoc-search: case-sensitive only when capitals are used)
 - rust-lang#133046 (Clippy subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e158303 into rust-lang:master Nov 15, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
@rust-timer
Unrolled build for rust-lang#128197
62b2a43 
Rollup merge of rust-lang#128197 - Alexendoo:span-ctxt, r=davidtwco

Skip locking span interner for some syntax context checks

- `from_expansion` now never needs to consult the interner
- `eq_ctxt` now only needs the interner when both spans are fully interned
@Alexendoo Alexendoo deleted the span-ctxt branch November 15, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexendoo @rustbot @davidtwco @bors