Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests which assert that import list for simple executable not changed silently #121494

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Feb 23, 2024

added tests for x86_64-pc-windows-msvc and x86_64-unknown-linux-gnu

@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2024
@rust-log-analyzer

This comment has been minimized.

@klensy klensy force-pushed the assert-import-list branch from 7ff4a0e to 3d28626 Compare February 23, 2024 10:37
@klensy klensy force-pushed the assert-import-list branch from 3d28626 to 9bae569 Compare February 23, 2024 10:53
@ChrisDenton
Copy link
Member

Is there are reason this in particular is useful? I would expect this to change as the C runtime changes between versions. And also a fair bit on the Rust side over time, especially around now as we're moving to a Windows 10 baseline.

@klensy
Copy link
Contributor Author

klensy commented Feb 24, 2024

Yes, but runtime changes not every day, same is true for transition to Windows 10 baseline (windows dependency list should be quite stable, but don't know about linux ones).

Plus this is additional guard against issues like #85441, #108714 (comment)

@klensy
Copy link
Contributor Author

klensy commented Feb 24, 2024

I'll probably add more variations to tests, like lto and stuff, they cut import list quite nice ,for example for x86_64-pc-windows-gnu

@klensy klensy marked this pull request as draft February 24, 2024 08:52
@klensy
Copy link
Contributor Author

klensy commented Feb 24, 2024

@author

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2024
@Dylan-DPC
Copy link
Member

@klensy any updates on this? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants