Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derive for core::marker::ConstParamTy #111649

Merged
merged 1 commit into from
May 17, 2023
Merged

Add derive for core::marker::ConstParamTy #111649

merged 1 commit into from
May 17, 2023

Conversation

Noratrieb
Copy link
Member

This makes it easier to implement it for a type, just like Copy.

@BoxyUwU half asked me to add it

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

BoxyUwU
BoxyUwU requested changes May 16, 2023
View reviewed changes
Copy link
Member

@BoxyUwU BoxyUwU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for:

  • derive(ConstParamTy, Eq, PartialEq) on a struct with a field that isnt ConstParamTy
  • derive(ConstParamTy) on a union that has a manual StructuralEq impl

r=me afterwards

@BoxyUwU
Copy link
Member

BoxyUwU commented May 16, 2023

r? @BoxyUwU

@rustbot rustbot assigned BoxyUwU and unassigned lcnr May 16, 2023
@Noratrieb
Add derive for core::marker::ConstParamTy
0336dd1 
This makes it easier to implement it for a type, just like `Copy`.
@Noratrieb Noratrieb force-pushed the derive-const-param-ty branch from eecc364 to 0336dd1 Compare May 16, 2023 18:09
BoxyUwU
BoxyUwU reviewed May 16, 2023
View reviewed changes
tests/ui/const-generics/adt_const_params/const_param_ty_impl_union.rs
impl Eq for Union {}
impl std::marker::StructuralEq for Union {}

impl std::marker::ConstParamTy for Union {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xd this should error oh well not this PR's fault

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, i'm glad i added a test at least 😆

@BoxyUwU
Copy link
Member

BoxyUwU commented May 16, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 16, 2023

📌 Commit 0336dd1 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request May 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2023
@bors
Auto merge of rust-lang#111671 - Dylan-DPC:rollup-1jy5r16, r=Dylan-DPC
c2ccc85 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110145 (Share slice of bytes)
 - rust-lang#111043 (Stabilize feature `cstr_is_empty`)
 - rust-lang#111648 (Remove `LangItems::require`)
 - rust-lang#111649 (Add derive for `core::marker::ConstParamTy`)
 - rust-lang#111654 (Add a conversion from `&mut T` to `&mut UnsafeCell<T>`)
 - rust-lang#111661 (Erase regions of type in `offset_of!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bc3b94a into rust-lang:master May 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 17, 2023
@Noratrieb Noratrieb deleted the derive-const-param-ty branch May 17, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU requested changes

Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Noratrieb @rustbot @BoxyUwU @bors @lcnr