Correct handling of non-numeric chars in parse_buf #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, int::parse_buf and uint::parse_buf return incorrect results for any strings that contain non-numeric characters. Fixes rust-lang#1102.
|
Sure, how about this? |
|
Cool. Integrated. |
bjorn3
added a commit
to bjorn3/rust
that referenced
this pull request
Nov 27, 2020
coastalwhite
pushed a commit
to coastalwhite/rust
that referenced
this pull request
Aug 5, 2023
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
* Remove unused --allow-cbmc-verification-failure flag * Cleaning up the kani arguments. - Removed --auto-unwind which as broken. - Fixed punctuation to be consistent. - Hide unstable / developer features from short help. * Fix --unwind conflict check We were not covering any other form of unwind. Note that this will also conflict with --unwinding-assertions which I think is probably fine since we have that option in Kani.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, int::parse_buf and uint::parse_buf return incorrect results for any strings that contain non-numeric characters. Fixes #1102.