Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] Prepare 1.66.0 release #105563

Merged
merged 16 commits into from
Dec 12, 2022
Merged

[stable] Prepare 1.66.0 release #105563

merged 16 commits into from
Dec 12, 2022

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Dec 11, 2022 •
edited
Loading

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 11, 2022
@pietroalbini
Copy link
Member Author

Need to finish the PR by backporting the release notes, will do so later today. Do not merge yet.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Dec 12, 2022
@pietroalbini pietroalbini marked this pull request as ready for review December 12, 2022 13:28
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@pietroalbini
Copy link
Member Author

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented Dec 12, 2022

📌 Commit 61b1219 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2022
@ehuss
Copy link
Contributor

ehuss commented Dec 12, 2022

@pietroalbini Just checking if you plan to accept or reject #104650 for backport? To be clear, I don't think that PR is required. The current builds seem to be working ok with xcode 14. The only reason I suggest it is because Apple documents it as not being supported, so we don't know what consequences there might be. It may also be a little strange to switch from 13 to 14 (in 1.66) and then back to 13 in 1.67.

There are also a few other nominated (though not approved) PRs.

@bors
Copy link
Contributor

bors commented Dec 12, 2022

⌛ Testing commit 61b1219 with merge ea14e00d83d87da23ceeb514d9c7186c6e7f83d9...

@pietroalbini
Copy link
Member Author

@bors r- retry

Yielding to the beta PR while we decide on last minute backports.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2022
@pietroalbini
Copy link
Member Author

Added backports for:

@bors r+ p=1000 rollup=never

@bors
Copy link
Contributor

bors commented Dec 12, 2022

📌 Commit 61b1219 has been approved by pietroalbini

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 12, 2022

⌛ Testing commit 61b1219 with merge 955121c4905d97ce2ee3c9969e7857fd6dc134cf...

@BlackHoleFox
Copy link
Contributor

BlackHoleFox commented Dec 12, 2022 •
edited
Loading

@pietroalbini I don't think that beta nomination of Build macOS distribution artifacts with XCode 13 was enough. Even after it, the macOS artifacts were still unusable on older macOS versions. The PR that actually fixed the regression was #105123. Nevermind, I understood wrong sorry.

@ehuss
Copy link
Contributor

ehuss commented Dec 12, 2022

@BlackHoleFox See my comment at #105563 (comment). I still lightly recommended it since Apple documents it as not being supported. #105123 is not necessary because the regression did not happen in beta.

@BlackHoleFox
Copy link
Contributor

@ehuss ahh, ok, many thanks for clearing that up. My brain skipped thinking about the past beta for some reason. I'm lined up with your thoughts on XCode 13 though.

@bors
Copy link
Contributor

bors commented Dec 12, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2022
@tmiasko @pietroalbini
Ignore errors when including clear_expected_if_blessed
c9aa73c 
Include is there only for the effect executing the rule.
The file is not intended to be remade successfully to be
actually included.
@pietroalbini
Copy link
Member Author

Backported #105477 to get CI working again.

@bors r+ p=1000 rollup=never

@pietroalbini pietroalbini reopened this Dec 12, 2022
@pietroalbini
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2022

📌 Commit c9aa73c has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2022
@bors
Copy link
Contributor

bors commented Dec 12, 2022

⌛ Testing commit c9aa73c with merge 69f9c33...

@ehuss
Copy link
Contributor

ehuss commented Dec 12, 2022

Backported #105477 to get CI working again.

Sorry, I forgot to tag that for beta-nominated.

@bors
Copy link
Contributor

bors commented Dec 12, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 69f9c33 to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 12, 2022
@bors bors merged commit 69f9c33 into rust-lang:stable Dec 12, 2022
@rustbot rustbot added this to the 1.66.0 milestone Dec 12, 2022
@pietroalbini pietroalbini deleted the pa-stable-1.66.0 branch December 12, 2022 19:57
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.