Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLD on Windows has supported natvis since early 2018, natvis can be embedded now #59383

Closed
TheGoddessInari opened this issue Mar 23, 2019 · 0 comments
Closed

LLD on Windows has supported natvis since early 2018, natvis can be embedded now #59383

TheGoddessInari opened this issue Mar 23, 2019 · 0 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@TheGoddessInari
Copy link
Contributor

According to llvm-mirror/lld@27b9c42 from exactly one year ago today. I'm not sure what versions would contain that commit, but I see no evidence that it's been reverted.

Given that LLVM 6, 7, and now 8 are out, it should be safe to remove the special case. Servo still recommends lld-link.
@jonas-schievink jonas-schievink added A-linkage Area: linking into static, shared libraries and binaries T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 23, 2019
@TheGoddessInari TheGoddessInari mentioned this issue Mar 26, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 28, 2019
@Centril
Rollup merge of rust-lang#59441 - TheGoddessInari:natvis, r=alexcrichton
02c1e3d 
Remove the block on natvis for lld-link.

Since rust-lang#56642 bumped minimum LLVM version to 6.0.0, Rust should be able to honor or ignore Windows natvis support with lld-link.

It looks like  llvm-mirror/lld@9133ca57b was in LLVM 7.0, while llvm-mirror/lld@27b9c4285 made it into 6.0, at least if the release branches are anything to go by.

Fixes rust-lang#59383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonas-schievink @TheGoddessInari