Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use statement not migrated #58004

Closed
Swoorup opened this issue Jan 30, 2019 · 2 comments
Closed

Use statement not migrated #58004

Swoorup opened this issue Jan 30, 2019 · 2 comments
Labels
A-edition-2018 Area: The 2018 edition A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@Swoorup
Copy link

Swoorup commented Jan 30, 2019

Use statements doesn't migrate to 2018 when using
cargo fix --edition

I later realized this was on a project which had all warnings turned off. Should rustfix, somehow understand warnings regardless of the warnings suppress by the user?

https://github.com/rustlang-cn/Rust-webapp-starter

@Enselic
Copy link
Member

Enselic commented Nov 19, 2023

Triage: I think this issue should be moved to https://github.com/rust-lang/rustfix/issues?

@ehuss
Copy link
Contributor

ehuss commented Nov 19, 2023

I believe this was fixed in 2021 via #85788 and rust-lang/cargo#9588. From what I can gather (the linked repo is no longer available), it sounds like they were allowing warnings. The force-warn system now forces warnings to be applied.

@Enselic, just FYI, the rustfix repo will be closing soon. Most suggested diagnostic issues should remain in this repo. Also, before transferring an issue, it is helpful to have a reproduction or enough information to assess where the issue lies.

@ehuss ehuss closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2023
@fmease fmease added A-edition-2018 Area: The 2018 edition A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. and removed A-edition-2018-lints labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2018 Area: The 2018 edition A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Development

No branches or pull requests

5 participants