-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mem.rs line numbers from const-size_of-cycle.stderr #53547
Comments
|
We scrub line numbers on the left, I wonder if we should do it for all paths, always. |
@eddyb I think it could make sense to keep line numbers for paths like it is now - I think there could be an (admittedly rare) case where a change causes an error to be reported on an incorrect line and that wouldn't be spotted (although, the highlighted code from the error would need to be the same on both lines - which isn't impossible, just unlikely). Either way, I'll put together a PR that normalizes these two cases for the time being. |
Submitted #53558 that adds normalization for this case to |
Normalize source line and column numbers. Fixes rust-lang#53547. r? @eddyb
rust/src/test/ui/consts/const-size_of-cycle.stderr
Line 5 in 1558ae7
It is not nice for this test to fail any time we insert a line in mem.rs, as happened in #53503. Please implement this test in a way that does not hardcode a line number.
Please also try to find standard library line numbers in other ui tests and scrub those in the same way.
As far as I can tell, the const-size_of-cycle.stderr file was newly added in #53196 so attn @davidtwco.
The text was updated successfully, but these errors were encountered: