Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--show-span should be a -Z option #30656

Closed
nrc opened this issue Dec 31, 2015 · 5 comments · Fixed by #30835
Closed

--show-span should be a -Z option #30656

nrc opened this issue Dec 31, 2015 · 5 comments · Fixed by #30835
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@nrc
Copy link
Member

nrc commented Dec 31, 2015

Not a breaking change since it is an unstable option.
@nrc nrc added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Dec 31, 2015
@jas-on
Copy link

jas-on commented Dec 31, 2015

Is it already an unstable option? https://github.com/rust-lang/rust/blob/master/src/librustc_driver/lib.rs#L143

@sfackler
Copy link
Member

@jas-on this issue is saying that --show-span should be changed to -Z show-span. It is already an unstable option.

@jas-on
Copy link

jas-on commented Dec 31, 2015

So show-span can accept expr|pat|ty as arguments. How would those be specified if show-span were changed to a -Z FLAG?

@nrc
Copy link
Member Author

nrc commented Jan 1, 2016

Hopefully exactly the same way, not sure how possible that is. If it is not possible right now, then this probably isn't an easy issue to fix. I can look into it next week.

@alexcrichton
Copy link
Member

We've got kinda our own syntax for the -Z flags so where today you pass --show-span foo it could instead be -Z show-span=foo

@kraai kraai mentioned this issue Jan 12, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jan 14, 2016
@Manishearth
Rollup merge of rust-lang#30835 - kraai:show-span, r=sanxiyn
4ff1d20 
I think this will fix rust-lang#30656.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace --show-span with -Z show-span
4 participants
@alexcrichton @nrc @sfackler @jas-on