Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro reform (Tracking issue for RFC 453) #20008

Closed
nikomatsakis opened this issue Dec 19, 2014 · 3 comments
Closed

Macro reform (Tracking issue for RFC 453) #20008

nikomatsakis opened this issue Dec 19, 2014 · 3 comments
Assignees
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)

Comments

@nikomatsakis
Copy link
Contributor

This is a tracking issue for RFC rust-lang/rfcs#453, macro reform.

@nikomatsakis
Copy link
Contributor Author

Assigning to Keegan McAllister since he is working on this at the moment.

@kmcallister kmcallister added the A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) label Dec 19, 2014
@kmcallister
Copy link
Contributor

Unimplemented parts of the RFC:

  • Renaming on #[macro_use] extern crate
  • Naming specific macros (and renaming?) on #[macro_use] mod
  • #[macro_use] on macro_rules! for helper macros
  • Lint for use of $crate in macros

I think all of these are backwards-compatible, and none of them is particularly high priority for 1.0.

@kmcallister
Copy link
Contributor

Renaming on import is now #22290.

The $crate lint sounds pretty hard the more I think about it. And it detects a problem that should be obvious at compile time, as soon as you try to use that macro in another crate.

The other two bullet points are things we could plausibly live without, so let's try that in the name of simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants