Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline comments mess with parser's line number state. #142

Closed
froystig opened this issue Aug 3, 2010 · 1 comment
Closed

Multiline comments mess with parser's line number state. #142

froystig opened this issue Aug 3, 2010 · 1 comment

Comments

@froystig
Copy link
Contributor

froystig commented Aug 3, 2010

By example:

// -*- rust -*-

/* 1
 * 2
 * 3
 */
fn main() {
  %; // parse error on line 8, but is reported on line 5 instead.
}
@graydon
Copy link
Contributor

graydon commented Aug 3, 2010

Fix some naughtiness of handling newlines in bracequotes and multi-line comments. Closed by a1ecdb1.

mbrubeck pushed a commit to mbrubeck/rust that referenced this issue Oct 17, 2011
oli-obk pushed a commit to oli-obk/rust that referenced this issue Jul 19, 2017
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
rchaser53 pushed a commit to rchaser53/rust that referenced this issue Jan 19, 2019
bors pushed a commit to rust-lang-ci/rust that referenced this issue Oct 1, 2021
Combine LanesAtMost32 and SimdArray into a single trait "Vector"

Attempts to fix some unresolved questions in rust-lang#139 regarding `SimdArray` having a generic parameter.

In particular, this made it not appropriate for replacing `LanesAtMost32`.  Additionally, it made it impossible to use in a context where you otherwise don't know the lane count, e.g. `impl Vector`.

An unfortunate side effect of this change is that scatter/gather no longer work in the trait (nor does anything else that references the lane count in a type.  This requires the super-unstable `const_evaluatable_checked` feature).

I also threw in the change from `as_slice` to `as_array` as discussed in zulip, and fixes rust-lang#51.
djtech-dev pushed a commit to djtech-dev/rust that referenced this issue Dec 9, 2021
Store LLVM version info directly in internal_macros
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Co-authored-by: Mark R. Tuttle <mrtuttle@amazon.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants