-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm-config sometimes doesn't provide the correct include directory #1311
Comments
There's a hack in mk/rustllvm.mk that adds it manually on windows. should be removed when we figure this out. |
Still relevant. |
Triage bump. I still see the hack, but don't know how to make progress with this. |
Triage. Hack still there, also unsure how to progress. |
Triage: same as what @reem said. |
Over a year later, my triage estimate is the same as it was last year. |
triage: ? |
Does anyone have a short example for reproducing this? |
@brson with the makefiles gone, is this still an issue or should this be looked into? |
Indeed I think this is no longer relevant! |
This allows using feature detection macros, without placing a requirement of enabled stdsimd feature gate from end users. A follow-up to changes from rust-lang#1311, which introduced the new macro.
llvm-config --cxxflags looks like this for me:
Critically, our build depends on that first include directory, under the source tree, for rustllvm. In some environments llvm-config doesn't give us that information, probably because it isn't realizing that it's being run out of the build directory.
The text was updated successfully, but these errors were encountered: