-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
std: Leak all statically allocated TLS keys
It turns out that rustrt::at_exit() doesn't actually occur after all pthread threads have exited (nor does atexit()), so there's not actually a known point at which we can deallocate these keys. It's not super critical that we do so, however, because we're about to exit anyway! Closes #19280
- Loading branch information
1 parent
54c628c
commit a4b1ac5
Showing
1 changed file
with
2 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4b1ac5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from aturon
at alexcrichton@a4b1ac5
a4b1ac5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/issue-19280 = a4b1ac5 into auto
a4b1ac5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/issue-19280 = a4b1ac5 merged ok, testing candidate = 5f9741e
a4b1ac5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2437
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2434
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2427
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2434
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2428
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2427
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2427
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2431
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2424
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2423
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2426
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2088
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2084
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2090
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/927
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/921
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/916
a4b1ac5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 5f9741e