Skip to content

Commit

Permalink
Rollup merge of #131728 - jieyouxu:boopstrap, r=onur-ozkan
Browse files Browse the repository at this point in the history
bootstrap: extract builder cargo to its own module

I was looking at our cargo rustflags/rustdocflags usages, and I found `builder.rs` to be a large
file which made it hard to digest. This PR tries to break out the cargo command wrapper parts to
its own submodule to make it easier to identify builder cargo-specific logic.

This PR:

- Extracts the cargo command wrapper to its own module and also move `Builder::{bare_,}cargo` impl
  to the submodule.
- Reorganizes some imports in `lib.rs` (no functional changes).
- Slightly adjusts some docs in `builder.rs`.

This PR is basically just moving code around, and should not contain any functional changes.

Before this PR, `builder.rs` was 2743 lines. After this PR, `builder.rs` is down to a more
manageable 1386 lines and `cargo.rs` is 1085 lines.
  • Loading branch information
matthiaskrgr authored Oct 21, 2024
2 parents 9ff4dab + 2b4bf2d commit 09a22b8
Show file tree
Hide file tree
Showing 3 changed files with 1,229 additions and 1,211 deletions.
Loading

0 comments on commit 09a22b8

Please sign in to comment.