Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup #8409

Merged
merged 12 commits into from
Feb 10, 2022
Merged

Rustup #8409

merged 12 commits into from
Feb 10, 2022

Conversation

flip1995
Copy link
Member

r? @ghost

changelog: none

flip1995 and others added 12 commits January 27, 2022 15:12
This will prevent unstable order when HirIds are pertubated.
Create `core::fmt::ArgumentV1` with generics instead of fn pointer

Split from (and prerequisite of) #90488, as this seems to have perf implication.

`@rustbot` label: +T-libs
it ignored regions and constants in adts,
but didn't do so for references or any other types.
This seemed quite weird
remove `TyS::same_type`

This function ignored regions and constants in adts, but didn't do so for references or any other types. cc rust-lang/rust#93148 (comment)
by using an opaque type obligation to bubble up comparisons between opaque types and other types

Also uses proper obligation causes so that the body id works, because out of some reason nll uses body ids for logic instead of just diagnostics.
Remove defaultness from ImplItem.

This information is not really used anywhere, except HIR pretty-printing. This makes ImplItem and TraitItem more similar.
@flip1995
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Feb 10, 2022

📌 Commit 49b9f92 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 10, 2022

⌛ Testing commit 49b9f92 with merge 57b3c4b...

@bors
Copy link
Contributor

bors commented Feb 10, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 57b3c4b to master...

@bors bors merged commit 57b3c4b into rust-lang:master Feb 10, 2022
@flip1995 flip1995 deleted the rustup branch February 10, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants