Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that RETURN_SELF_NOT_MUST_USE is not emitted if the method already has #[must_use] #8143

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Dec 18, 2021

Fixes #8140.


Edit:

changelog: none

(The lint is not in beta yet, this should therefore not be included inside the changelog :) )

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 18, 2021
@xFrednet
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 18, 2021

📌 Commit 4da5520 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Dec 18, 2021

⌛ Testing commit 4da5520 with merge 25e90ec...

@bors
Copy link
Contributor

bors commented Dec 18, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 25e90ec to master...

@bors bors merged commit 25e90ec into rust-lang:master Dec 18, 2021
@GuillaumeGomez GuillaumeGomez deleted the RETURN_SELF_NOT_MUST_USE branch December 18, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return_self_not_must_use contradicts double_must_use for #[must_use]-types
5 participants