Pluralize disallowed_type lint
#7984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
phansch
force-pushed
the
disallowed-type-rename
branch
from
82c81fb to
399c5eb
Compare
flip1995
reviewed
Nov 17, 2021
|
r? @flip1995 (I want to get this merged by tomorrow. So assigning it to myself, so I'm to blame if it's not merged by then) |
flip1995
force-pushed
the
disallowed-type-rename
branch
3 times, most recently
from
3ad9ba6 to
8183ed5
Compare
|
r? @xFrednet Since I updated the PR, I'll now push it forward for a third pair of eyes. |
phansch
commented
Nov 18, 2021
This was brought up in [Zulip] and is also mentioned in the lint naming conventions. Since this is still a nursery lint, I think there shouldn't be any problem in renaming it. [Zulip]: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/disallow_type.20vs.20disallowed-types
This way they match up with the pluralized lint name as well.
To stay consistent with the sister lint disallowed_type, also rename the disallowed_method lint to disallowed_methods.
flip1995
force-pushed
the
disallowed-type-rename
branch
from
8183ed5 to
9b38fb7
Compare
xFrednet
approved these changes
Nov 19, 2021
|
LGTM, thanks! @bors r+ |
|
📌 Commit 9b38fb7 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was brought up in Zulip and is also mentioned in the lint naming
conventions. Since this is still a nursery lint, I think there shouldn't
be any problem in renaming it.
changelog: Rename nursery lint [
disallowed_type] to [disallowed_types].