Fix invocation of zst_offset lint

[ranweiler]

The zst_offset lint was broken by a refactoring regression in 2108387. In the invocation of the zst_offset check here, we shadow the already-destructured receiver recv, and accidentally pass the first argument of the method as if it were the receiver.

This was not caught because the UI test expectation was never correct (a bad cast obscured the actual test result).

This PR:

• Fixes the existing test expectation
• Tests both const and mut raw pointers
• Passes the actual receiver to the lint's implementation

Fixes #7395.

changelog: Fix [zst_offset] invocation and test

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[ranweiler]

This was the invalid cast that prevented testing the actual lint.

[Manishearth]

@bors r+

thanks!

[bors]

📌 Commit 642239c has been approved by Manishearth

[bors]

⌛ Testing commit 642239c with merge d568387...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing d568387 to master...