Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template #7112

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

giraffate
Copy link
Contributor

A follow-up of #7064 (comment).

changelog: none

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 19, 2021
@camsteffen
Copy link
Contributor

This is kinda weird. Like a half-baked markdown link? Could we train our changelog collector script to do this automagically?

@giraffate
Copy link
Contributor Author

Like a half-baked markdown link?

We already have a reference-style link like this: 5af078a#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR2219 in CHANGELOG.md. So I think it seems to work.

@camsteffen
Copy link
Contributor

I see. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2021

📌 Commit 2d65b2d has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Apr 19, 2021

⌛ Testing commit 2d65b2d with merge a3b1efd...

@bors
Copy link
Contributor

bors commented Apr 19, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing a3b1efd to master...

@bors bors merged commit a3b1efd into rust-lang:master Apr 19, 2021
@giraffate giraffate deleted the update_pull_request_template branch April 19, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants