new manual_option_as_slice lint
#13901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
llogiq
force-pushed
the
manual-option-as-slice
branch
2 times, most recently
from
b3fb332 to
44b74b4
Compare
|
r? @blyxyas |
llogiq
force-pushed
the
manual-option-as-slice
branch
2 times, most recently
from
a037517 to
733cde9
Compare
blyxyas
reviewed
Jan 19, 2025
blyxyas
requested changes
Jan 20, 2025
llogiq
force-pushed
the
manual-option-as-slice
branch
2 times, most recently
from
98326c0 to
0ed4623
Compare
llogiq
force-pushed
the
manual-option-as-slice
branch
3 times, most recently
from
b8e8b12 to
c548460
Compare
blyxyas
approved these changes
Jan 26, 2025
llogiq
force-pushed
the
manual-option-as-slice
branch
from
c548460 to
33256d8
Compare
Alexendoo
reviewed
Jan 26, 2025
llogiq
force-pushed
the
manual-option-as-slice
branch
from
33256d8 to
13be95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks. It's been a while since I added the
as_slicemethod toOption, and I totally forgot about a lint to suggest it. Well, I had some time around Christmas, so here it is now.changelog: add [
manual_option_as_slice] lint