assert! on == should be assert_eq!

[Apanatshka]

What it does

1. Find uses of assert! on the result of std::cmp::PartialEq::eq, suggest using assert_eq!.
2. Do the same for debug_assert_eq!.

Advantage

An assertion failure can output a more useful message.

Drawbacks

No response

Example

assert!(
    self.some_method()
        == local_value
            .get_other_information(self.complex.expression[0], this.is.long),
    "The some_method result must be in sync with the other information."
);

Could be written as:

assert_eq!(
    self.some_method(),
    local_value.get_other_information(self.complex.expression[0], this.is.long),
    "The some_method result must be in sync with the other information."
);

[nicklimmm]

The lint for the above is deprecated from #2156.

From rust-lang/rust#44838, seems like we are heading towards a better assert! macro with better messages.

[Apanatshka]

I was unaware of the planned changes, happy to hear that things will become better automatically :)