Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual: Convert to mdbook #19015

Merged
merged 1 commit into from
Jan 28, 2025
Merged

manual: Convert to mdbook #19015

merged 1 commit into from
Jan 28, 2025

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Jan 23, 2025

Split manual.adoc into markdown files, one for each chapter.

For the parts of the manual that are generated from source code doc comments, update the comments to use markdown syntax and update the code generators to write to generated.md files.

For the weekly release, stop copying the .adoc files to the rust-analyzer/rust-analyzer.github.io at release time. Instead, we'll sync the manual hourly from this repository.

See rust-analyzer/rust-analyzer.github.io#226 for the sync. This PR should be merged first, and that PR needs to be merged before the next weekly release.

This change is based on #15795, but rebased and updated. I've also manually checked each page for markdown syntax issues and fixed any I encountered.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2025
@Wilfred Wilfred force-pushed the mdbook branch 3 times, most recently from 2724f7c to 3380e4e Compare January 24, 2025 21:13
Split manual.adoc into markdown files, one for each chapter.

For the parts of the manual that are generated from source code doc
comments, update the comments to use markdown syntax and update the
code generators to write to `generated.md` files.

For the weekly release, stop copying the .adoc files to the
`rust-analyzer/rust-analyzer.github.io` at release time. Instead,
we'll sync the manual hourly from this repository.

See rust-analyzer/rust-analyzer.github.io#226
for the sync. This PR should be merged first, and that PR needs to be
merged before the next weekly release.

This change is based on rust-lang#15795, but rebased and updated. I've also
manually checked each page for markdown syntax issues and fixed any I
encountered.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Co-authored-by: Josh Rotenberg <joshrotenberg@gmail.com>
@Veykril
Copy link
Member

Veykril commented Jan 25, 2025

Instead, we'll sync the manual hourly from this repository.

That seems a bit excessive, once a day should suffice I feel like.

Let's merge this next week after the new release then.

@joshrotenberg
Copy link
Contributor

Woohoo, glad to see this is still alive! Happy to help out if I can.

@Veykril
Copy link
Member

Veykril commented Jan 28, 2025

@lnicola do we wanna merge this then? (and change the cron job time on the webpage repo PR?) Asking you since it is release related and so might cause you trouble

@lnicola
Copy link
Member

lnicola commented Jan 28, 2025

@Veykril let's get this thing out of the gate. We can tweak the cron job later, at least this way we'll know it it's working.

@Veykril Veykril added this pull request to the merge queue Jan 28, 2025
Merged via the queue into rust-lang:master with commit 07a09c1 Jan 28, 2025
9 checks passed
@Wilfred Wilfred deleted the mdbook branch January 28, 2025 18:18
@Veykril
Copy link
Member

Veykril commented Feb 3, 2025

Big thanks to the people involved, especially @joshrotenberg of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants