Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

feat: update lsp_types to the latest version #1768

Closed
wants to merge 3 commits into from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Mar 12, 2022

  • feat: update lsp_types to the latest version:
    • This required adding some optional fields
    • Updating the progress reporter
    • Using u32 in some places instead of u64
    • Passing the correct type as the request/response
    • Changing the enum field cases to upper case

@aminya aminya force-pushed the master branch 3 times, most recently from e8eb0db to 576073a Compare March 12, 2022 13:41
@aminya
Copy link
Contributor Author

aminya commented Mar 13, 2022

After debugging the code for some time, I cannot find the reason why the 9 remaining tests are failing. Any help would be appreciated.

using this in the find_impls test seems to fix the issue, but modifying the tests like this looks random to me.

                work_done_progress_params: WorkDoneProgressParams {
                    work_done_token: Some(NumberOrString::String("progress_1".to_owned())),
                },

cc: @Xanewok

@aminya aminya marked this pull request as draft April 13, 2022 06:49
@calebcartwright
Copy link
Member

Just a heads up that this is unlikely to get any eyes or be merged because RLS is being deprecated in favor of Rust Analyzer

rust-lang/blog.rust-lang.org#979

@aminya aminya closed this Jun 11, 2022
@aminya
Copy link
Contributor Author

aminya commented Jun 11, 2022

Moved to 1778

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants