This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Avoid void-params deserialize errors #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! That's a pretty glorious hack! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves to permissive deserialisation of request void-params. Currently if a client sends a requests with non-null params, ie a
{}, we error. But in the case the params end up as()we're better served just continuing.Technically this was actually more of a pain than it seemed. With our use of generics it's not easy to tell if params are
(). Without specialisation I can't add an additional implementation for void param requests.Instead I used
size_of<R::Params> == 0to deduce that the params are void-type and put in a workaround.Fixes #1038