Update for field reordering #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry for the delay! I think it would be better to just remove the note altogether? I think I just added this to avoid getting complaints about "why doesn't the compiler do this the book said so!" what do you think? |
|
Great idea! Moreover, maybe we should replace it with something like: "Rust compiler does field reordering when not using repr(c)", make it more clear to the reader. |
|
I think that's the whole point of this section, (and the one on repr(C)), so I don't think that will be necessary. |
|
Ok, I removed the notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rust-lang/rust/blob/master/RELEASES.md
rust-lang/rust#40377