Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update memmap to memmap2. #156

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Update memmap to memmap2. #156

merged 1 commit into from
Mar 19, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Mar 18, 2021 •
edited by wesleywiser
Loading

memmap is no longer maintained. memmap2 is a fork that is still maintained. https://rustsec.org/advisories/RUSTSEC-2020-0077.html

cc rust-lang/rust#83236

Fixes #153

@joshtriplett
Copy link
Member

This updates the dependency, but doesn't update the usage in measureme/src/counters.rs, which still does use memmap.

@joshtriplett
Copy link
Member

Looks good to me.

@wesleywiser wesleywiser merged commit d5050c0 into rust-lang:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0077: memmap is unmaintained
3 participants
@cjgillot @joshtriplett @wesleywiser