WIP: Port crates#index to use Diesel
#600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the tests are failing since they set up their test data using the rust-postgres connection, and I still need to port them over. I'm done for the evening though, and I doubt porting the tests will change the code significantly, so I figured I'd toss this up now to see if there's any feedback.
| @@ -0,0 +1 @@ | |||
| ALTER TABLE versions ALTER COLUMN yanked SET NOT NULL; | |||
There was a problem hiding this comment.
inb4 prod has a ton of rows where this is null
| @@ -54,7 +54,8 @@ impl App { | |||
| .helper_threads(if config.env == ::Env::Production {3} else {1}) | |||
| .build(); | |||
| let diesel_db_config = r2d2::Config::builder() | |||
| .pool_size(if config.env == ::Env::Production {1} else {1}) | |||
| .pool_size(if config.env == ::Env::Production {50} else {1}) | |||
There was a problem hiding this comment.
This 50 is going to have to come down as we discovered yesterday
There was a problem hiding this comment.
I thought prod had 120 connections available? I told it to not try to keep more than 5 idles at a time so it should never get bad on staging.
There was a problem hiding this comment.
Oh I see. I thought this would mean I couldn't deploy it to staging.
There was a problem hiding this comment.
Wait... min_idle means "not more than 5 idles"? That sounds like max_idles to me...?
There was a problem hiding this comment.
Yeah, r2d2's naming/behavior/defaults are all really questionable here.
There was a problem hiding this comment.
You could totally take down staging by sending 20 concurrent requests though, but I figured that's not a huge concern.
| #[derive(Associations)] | ||
| #[belongs_to(Category)] | ||
| #[table_name="crates_categories"] | ||
| #[allow(dead_code)] // FIXME: Hey @sgrif add better many-to-many support to Diesel, wouldya? |
|
This requires porting more endpoints than I thought. Going after some other endpoints for now. No point leaving this open. |
bors
added a commit
that referenced
this pull request
Dec 18, 2019
…-ember-7.7.2, r=Turbo87 Bump eslint-plugin-ember from 7.0.0 to 7.7.2 Bumps [eslint-plugin-ember](https://github.com/ember-cli/eslint-plugin-ember) from 7.0.0 to 7.7.2. <details> <summary>Release notes</summary> *Sourced from [eslint-plugin-ember's releases](https://github.com/ember-cli/eslint-plugin-ember/releases).* > ## v7.7.2 > #### 🐛 Bug Fix > * [#621](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/621) Fix false positive with `ignoreNonThisExpressions` option in `use-ember-get-and-set` rule ([@​Exelord](https://github.com/Exelord)) > > #### 📝 Documentation > * [#620](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/620) Use consistent prefixes for rule descriptions ([@​bmish](https://github.com/bmish)) > > #### 🏠 Internal > * [#625](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/625) Add eslint-plugin-jest internally and enable rules ([@​bmish](https://github.com/bmish)) > * [#624](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/624) Add eslint-plugin-unicorn internally and enable recommended rules ([@​bmish](https://github.com/bmish)) > > #### Committers: 2 > - Bryan Mishkin ([@​bmish](https://github.com/bmish)) > - Maciej Kwaśniak ([@​Exelord](https://github.com/Exelord)) > > ## v7.7.1 > #### 🐛 Bug Fix > * [#615](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/615) Fix issue causing assert to fire in `getSourceModuleName` util function ([@​patocallaghan](https://github.com/patocallaghan)) > > #### Committers: 1 > - Pat O'Callaghan ([@​patocallaghan](https://github.com/patocallaghan)) > > ## v7.7.0 > #### 🚀 Enhancement > * [#592](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/592) Update `no-classic-classes` rule to catch classic Ember Data model classes ([@​patocallaghan](https://github.com/patocallaghan)) > > #### 🐛 Bug Fix > * [#610](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/610) Fix invalid `no-get` rule autofix caused by invalid JS variable name ([@​bmish](https://github.com/bmish)) > * [#607](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/607) Fix spread property bug in `require-super-in-init` rule ([@​bmish](https://github.com/bmish)) > * [#600](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/600) Add missing schema validation for options on many rules ([@​bmish](https://github.com/bmish)) > > #### 🏠 Internal > * [#611](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/611) Add many missing tests for lines without test coverage ([@​bmish](https://github.com/bmish)) > > #### Committers: 2 > - Bryan Mishkin ([@​bmish](https://github.com/bmish)) > - Pat O'Callaghan ([@​patocallaghan](https://github.com/patocallaghan)) > > ## v7.6.0 > #### 🚀 Enhancement > * [#594](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/594) Add new rule `no-get-with-default` ([@​steventsao](https://github.com/steventsao)) > > #### Committers: 1 > - Steven Tsao ([@​steventsao](https://github.com/steventsao)) > > ## v7.5.0 > #### 🚀 Enhancement > * [#583](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/583) Update `no-observers` rule to handle decorators ([@​bmish](https://github.com/bmish)) > * [#577](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/577) Add autofixer to `no-get` rule ([@​bmish](https://github.com/bmish)) > ></tr></table> ... (truncated) </details> <details> <summary>Changelog</summary> *Sourced from [eslint-plugin-ember's changelog](https://github.com/ember-cli/eslint-plugin-ember/blob/master/CHANGELOG.md).* > ## v7.7.2 (2019-12-12) > > #### 🐛 Bug Fix > * [#621](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/621) Fix false positive with `ignoreNonThisExpressions` option in `use-ember-get-and-set` rule ([@​Exelord](https://github.com/Exelord)) > > #### 📝 Documentation > * [#620](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/620) Use consistent prefixes for rule descriptions ([@​bmish](https://github.com/bmish)) > > #### 🏠 Internal > * [#625](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/625) Add eslint-plugin-jest internally and enable rules ([@​bmish](https://github.com/bmish)) > * [#624](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/624) Add eslint-plugin-unicorn internally and enable recommended rules ([@​bmish](https://github.com/bmish)) > > #### Committers: 2 > - Bryan Mishkin ([@​bmish](https://github.com/bmish)) > - Maciej Kwaśniak ([@​Exelord](https://github.com/Exelord)) > > ## v7.7.1 (2019-11-29) > > #### 🐛 Bug Fix > * [#615](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/615) Fix issue causing assert to fire in `getSourceModuleName` util function ([@​patocallaghan](https://github.com/patocallaghan)) > > #### Committers: 1 > - Pat O'Callaghan ([@​patocallaghan](https://github.com/patocallaghan)) > > ## v7.7.0 (2019-11-29) > > #### 🚀 Enhancement > * [#592](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/592) Update `no-classic-classes` rule to catch classic Ember Data model classes ([@​patocallaghan](https://github.com/patocallaghan)) > > #### 🐛 Bug Fix > * [#610](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/610) Fix invalid `no-get` rule autofix caused by invalid JS variable name ([@​bmish](https://github.com/bmish)) > * [#607](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/607) Fix spread property bug in `require-super-in-init` rule ([@​bmish](https://github.com/bmish)) > * [#600](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/600) Add missing schema validation for options on many rules ([@​bmish](https://github.com/bmish)) > > #### 🏠 Internal > * [#611](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/611) Add many missing tests for lines without test coverage ([@​bmish](https://github.com/bmish)) > > #### Committers: 2 > - Bryan Mishkin ([@​bmish](https://github.com/bmish)) > - Pat O'Callaghan ([@​patocallaghan](https://github.com/patocallaghan)) > > ## v7.6.0 (2019-11-19) > > #### 🚀 Enhancement > * [#594](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/pull/594) Add new rule `no-get-with-default` ([@​steventsao](https://github.com/steventsao)) > > #### Committers: 1 > - Steven Tsao ([@​steventsao](https://github.com/steventsao)) > > ## v7.5.0 (2019-11-11) ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`1805883`](ember-cli/eslint-plugin-ember@1805883) v7.7.2 - [`39539bc`](ember-cli/eslint-plugin-ember@39539bc) Update CHANGELOG - [`9943b7e`](ember-cli/eslint-plugin-ember@9943b7e) Merge pull request [#625](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/issues/625) from bmish/eslint-plugin-jest - [`cb4824d`](ember-cli/eslint-plugin-ember@cb4824d) chore(lint): add eslint-plugin-jest internally and enable rules - [`dc149b5`](ember-cli/eslint-plugin-ember@dc149b5) Merge pull request [#624](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/issues/624) from bmish/eslint-plugin-unicorn - [`9a6a4be`](ember-cli/eslint-plugin-ember@9a6a4be) chore(lint): add eslint-plugin-unicorn internally and autofix recommended rules - [`c93198c`](ember-cli/eslint-plugin-ember@c93198c) build(deps-dev): bump eslint-plugin-import from 2.18.2 to 2.19.1 ([#623](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/issues/623)) - [`e2c5235`](ember-cli/eslint-plugin-ember@e2c5235) build(deps): bump snake-case from 3.0.1 to 3.0.2 ([#622](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/issues/622)) - [`4c6aedd`](ember-cli/eslint-plugin-ember@4c6aedd) Merge pull request [#621](https://github-redirect.dependabot.com/ember-cli/eslint-plugin-ember/issues/621) from Exelord/fix/ignore-this-expressions - [`ed6301a`](ember-cli/eslint-plugin-ember@ed6301a) chore: fix lint violation - Additional commits viewable in [compare view](ember-cli/eslint-plugin-ember@v7.0.0...v7.7.2) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=eslint-plugin-ember&package-manager=npm_and_yarn&previous-version=7.0.0&new-version=7.7.2) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests are failing since they set up their test data using the
rust-postgres connection, and I still need to port them over. I'm done
for the evening though, and I doubt porting the tests will change the
code significantly, so I figured I'd toss this up now to see if there's
any feedback.