Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose erf{,c}{,f} from libm #753

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV
Copy link
Contributor Author

Rebased on top of #754 to please clippy.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine but I'm not going to merge it yet. The update to compiler-builtins in r-l/rust is more or less blocked, I'm going to wait for that to flush before adding any more functionality to compiler-builtins on the off chance it causes errors.

@tgross35
Copy link
Contributor

tgross35 commented Feb 6, 2025

Wound up reverting the blocking PR so this is unstuck

@tgross35 tgross35 merged commit 4b67aba into rust-lang:master Feb 6, 2025
26 checks passed
@GrigorenkoPV GrigorenkoPV deleted the erf branch February 6, 2025 23:43
tgross35 added a commit to tgross35/rust that referenced this pull request Feb 7, 2025
Exposes the error function so we can expose this in the standard
library.

[1]: rust-lang/compiler-builtins#753
tgross35 added a commit to tgross35/rust that referenced this pull request Feb 7, 2025
Exposes the error function so we can expose this in the standard
library [1].

[1]: rust-lang/compiler-builtins#753
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 10, 2025
Update `compiler-builtins` to 0.1.146

Exposes the error function so we can expose this in the standard library [1].

[1]: rust-lang/compiler-builtins#753
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 10, 2025
Update `compiler-builtins` to 0.1.146

Exposes the error function so we can expose this in the standard library [1].

[1]: rust-lang/compiler-builtins#753
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
Rollup merge of rust-lang#136714 - tgross35:update-builtins, r=tgross35

Update `compiler-builtins` to 0.1.146

Exposes the error function so we can expose this in the standard library [1].

[1]: rust-lang/compiler-builtins#753
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 11, 2025
Update `compiler-builtins` to 0.1.146

Exposes the error function so we can expose this in the standard library [1].

[1]: rust-lang/compiler-builtins#753
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Feb 13, 2025
Exposes the error function so we can expose this in the standard
library [1].

[1]: rust-lang/compiler-builtins#753
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Feb 13, 2025
Update `compiler-builtins` to 0.1.146

Exposes the error function so we can expose this in the standard library [1].

[1]: rust-lang/compiler-builtins#753
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Feb 22, 2025
Exposes the error function so we can expose this in the standard
library [1].

[1]: rust-lang/compiler-builtins#753
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request Feb 22, 2025
Exposes the error function so we can expose this in the standard
library [1].

[1]: rust-lang/compiler-builtins#753
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Feb 22, 2025
Exposes the error function so we can expose this in the standard
library [1].

[1]: rust-lang/compiler-builtins#753
github-actions bot pushed a commit to thanhnguyen-aws/verify-rust-std that referenced this pull request Feb 22, 2025
Exposes the error function so we can expose this in the standard
library [1].

[1]: rust-lang/compiler-builtins#753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants