Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some fix tests on stable #6072

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

dwijnand
Copy link
Member

No description provided.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 21, 2018

📌 Commit 008ab7203c5c41e28af26964dbb0b4b449458d94 has been approved by alexcrichton

@alexcrichton alexcrichton reopened this Sep 21, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 21, 2018

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Sep 21, 2018

📌 Commit 008ab7203c5c41e28af26964dbb0b4b449458d94 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 21, 2018

☔ The latest upstream changes (presumably #6068) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Sep 22, 2018

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout enable-some-fix-tests (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self enable-some-fix-tests --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging tests/testsuite/fix.rs
CONFLICT (content): Merge conflict in tests/testsuite/fix.rs
Automatic merge failed; fix conflicts and then commit the result.

@dwijnand dwijnand force-pushed the enable-some-fix-tests branch from 008ab72 to a7b1c4e Compare September 22, 2018 06:18
@dwijnand
Copy link
Member Author

@bors r=alexcrichton (trust me, bot!)

@bors
Copy link
Contributor

bors commented Sep 25, 2018

@dwijnand: 🔑 Insufficient privileges: Not in reviewers

@Mark-Simulacrum
Copy link
Member

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Sep 25, 2018

📌 Commit a7b1c4e has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 25, 2018

⌛ Testing commit a7b1c4e with merge 35cd245...

bors added a commit that referenced this pull request Sep 25, 2018
@bors
Copy link
Contributor

bors commented Sep 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 35cd245 to master...

@bors bors merged commit a7b1c4e into rust-lang:master Sep 25, 2018
@dwijnand dwijnand deleted the enable-some-fix-tests branch September 25, 2018 19:18
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants