Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdbook: reduce deps #3912

Closed
wants to merge 1 commit into from
Closed

mdbook: reduce deps #3912

wants to merge 1 commit into from

Conversation

klensy
Copy link

@klensy klensy commented May 6, 2024

Don't use default features for mdbook, they pull too many deps, looks unused? Noticed in rust-lang/rust#124815. Well, tests will show if it works.

@klensy
mdbook: reduce deps
a5d6146 
don't use default features for mdbook, they pull too many deps
@chriskrycho
Copy link
Contributor

Thanks for the suggestion, but the default features are watch, serve, and search, and we use all of them quite a bit. The watch and serve workflows are ones we use all the time as part of development, and search is definitely very used on the site itself!

@chriskrycho chriskrycho closed this May 9, 2024
@klensy
Copy link
Author

klensy commented May 9, 2024 •
edited
Loading

Well, CI didn't failed?

@chriskrycho
Copy link
Contributor

CI doesn't run every single part of what we use for development. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klensy @chriskrycho